Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor blas/ext/base/dcusumkbn to follow current project conventions #2025

Closed
wants to merge 12 commits into from
Closed

refactor blas/ext/base/dcusumkbn to follow current project conventions #2025

wants to merge 12 commits into from

Conversation

itskdhere
Copy link
Contributor

@itskdhere itskdhere commented Mar 24, 2024 •
edited
Loading

Resolves #1472 .

Description

What is the purpose of this pull request?

This pull request:

  • refactors the existing implementation of blas/ext/base/dcusumkbn to follow the current project convention.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 24, 2024
stdlib-bot
stdlib-bot reviewed Mar 24, 2024
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@Planeshifter Planeshifter added Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. Needs Review A pull request which needs code review. labels Mar 25, 2024
Planeshifter
Planeshifter requested changes Mar 25, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

Did an initial review and flagged some issues that will have to be addressed before merging.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 25, 2024
@itskdhere
Copy link
Contributor Author

@Planeshifter I've made the requested changes.

@itskdhere
Copy link
Contributor Author

itskdhere commented Mar 25, 2024 •
edited
Loading

I think, I made some big mistakes: 64008be & 64ddf87

Should I open a new PR ?

@Pranavchiku
Copy link
Member

If you are unable to revert those here, please feel free to open a new PR and close this referring to new one.

@itskdhere
Copy link
Contributor Author

If you are unable to revert those here, please feel free to open a new PR and close this referring to new one.

Ok, working on it. Thanks for the clarification.

@itskdhere
Copy link
Contributor Author

I'm closing this PR and opened a new PR #2036 . Please take a look into that:


And sorry for the inconvenience 🙏

@itskdhere itskdhere closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@Planeshifter Planeshifter Planeshifter requested changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dcusumkbn to follow current project conventions
4 participants
@itskdhere @Pranavchiku @Planeshifter @stdlib-bot