Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: refactor math/base/special/cexp to follow latest project conventions #3393

Open
3 tasks done
aayush0325 opened this issue Dec 10, 2024 · 2 comments · May be fixed by #3394
Open
3 tasks done

[RFC]: refactor math/base/special/cexp to follow latest project conventions #3393

aayush0325 opened this issue Dec 10, 2024 · 2 comments · May be fixed by #3394
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Math Issue or pull request specific to math functionality. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@aayush0325
Copy link
Contributor

Description

This RFC proposes refactoring of math/base/special/cexp to use in house stdlib functions for operations like exp, sin, cos and copysign.

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@aayush0325 aayush0325 linked a pull request Dec 10, 2024 that will close this issue
Open
1 task
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Math Issue or pull request specific to math functionality. Accepted RFC feature request which has been accepted. priority: Normal Normal priority concern or feature request. C Issue involves or relates to C. labels Dec 10, 2024
@kgryte
Copy link
Member

kgryte commented Dec 10, 2024

@aayush0325 Thanks for opening this issue. Yes, we should definitely update to use stdlib functions and also replace the usage of the INFINITY and NAN macros. For the former, we have a constant package. For the latter, we should just use 0.0 / 0.0.

@aayush0325
Copy link
Contributor Author

@kgryte i have done just that in the pr linked to this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Math Issue or pull request specific to math functionality. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: update math/base/special/cexp to follow latest project conventions aayush0325/stdlib
2 participants
@kgryte @aayush0325