Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: refactor blas/ext/base/dcusumors to follow current project conventions #1474

Closed
3 tasks done
Planeshifter opened this issue Mar 3, 2024 · 1 comment · Fixed by #2041
Closed
3 tasks done

[RFC]: refactor blas/ext/base/dcusumors to follow current project conventions #1474

Planeshifter opened this issue Mar 3, 2024 · 1 comment · Fixed by #2041
Assignees
@itskdhere
Labels
Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.

Comments

@Planeshifter
Copy link
Member

Description

This RFC proposes refactoring @stdlib/blas/ext/base/dcusumors to follow current project conventions.

These conventions are outlined in more detail in #788. Namely, we want to migrate from C++ add-on interfaces to C add-on interfaces and then make various style and simplification changes.

Some example commits which perform most, if not all, of the requested changes include d66d80c (saxpy), 3c82fe7 (cswap), and 5b15c96 (dasum).

Related Issues

Related issues #788, #1152.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Planeshifter Planeshifter added Native Addons Issue involves or relates to Node.js native add-ons. Good First Issue A good first issue for new contributors! priority: High High priority concern or feature request. JavaScript Issue involves or relates to JavaScript. labels Mar 3, 2024
@itskdhere
Copy link
Contributor

while my another PR is under review, I'm working on this.

@itskdhere itskdhere mentioned this issue Mar 25, 2024
Merged
1 task
Planeshifter added a commit that referenced this issue Mar 26, 2024
@itskdhere @Pranavchiku @Planeshifter
refactor blas/ext/base/dcusumors to follow current project conventions
d56c235 
PR-URL: #2041
Closes: #1474

---------

Signed-off-by: Pranav <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Pranav <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Pranav Goswami <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itskdhere itskdhere

Labels
Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor blas/ext/base/dcusumors to follow current project conventions itskdhere/stdlib
2 participants
@Planeshifter @itskdhere