Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test about 1k of existing validators on one or two nodes with Primev mev-commit #188

Closed
tersec opened this issue Jul 11, 2024 · 17 comments
Closed
Assignees

Comments

@tersec
Copy link

tersec commented Jul 11, 2024

https://docs.primev.xyz/get-started/validators

@jakubgs
Copy link
Member

jakubgs commented Jul 11, 2024

My understanding is that this involves selecting a few nodes from one Holesky host, and staking their validators on Primev.

For example nodes with 700 validators each would be a good candidate probably:

'geth-08.ih-eu-mda1.nimbus.holesky': # 700 each
- { branch: 'stable', start: 2200, end: 2900, el: 'geth', vc: true }
- { branch: 'testing', start: 2900, end: 3600, el: 'geth', vc: false }
- { branch: 'unstable', start: 3600, end: 4300, el: 'geth', vc: false, nim_commit: 'version-2-0', payload_builder: true }
- { branch: 'libp2p', start: 4300, end: 5000, el: 'geth', vc: false }

@tersec would you rather have all nodes on one host? Or would you prefer a spread across the 3 types of EL nodes we have?
If so nodes with 400 validators each would probably make most sense.

Also, would we prefer a specific BN branch, like unstable, or dies it no matter in this case?

@shaspitz
Copy link

Hey all! Seems like you're on the right track here. The only thing you'll need from the validator registry contract's perspective is an EOA with some eth and the list of BLS pubkeys that will be staked in batches. How those validator pubkeys correspond to your node config is up to you. Lmk if you have any questions about the opt in process

@techgangboss
Copy link

techgangboss commented Jul 22, 2024

hey guys @tersec @jakubgs let us know if we can finalize this, we'll be announcing the dashboard soon and would love to involve your validators (and support from Nimbus. we won't be mentioning names however unless you'd like for us to)

@yakimant
Copy link
Member

yakimant commented Aug 5, 2024

Alright, here is what I understand what we need:

Correct me if I'm wrong with list or order.

@shaspitz
Copy link

shaspitz commented Aug 6, 2024

Alright, here is what I understand what we need:

Correct me if I'm wrong with list or order.

Sounds correct to me!

@yakimant
Copy link
Member

mev-boost - beacon-node works well according to the logs:

beacon-node:

{"lvl":"INF","ts":"2024-08-13 12:18:40.170+00:00","msg":"Using external payload builder","topics":"beacnde","payloadBuilderUrl":"http://localhost:18550"}
{"lvl":"DBG","ts":"2024-08-13 12:19:23.403+00:00","msg":"Sending REST request to remote server","remote":"localhost:18550","request":"/eth/v1/builder/validators","http_method":"POST"}
{"lvl":"DBG","ts":"2024-08-13 12:19:23.404+00:00","msg":"Opened connection to remote server","remote":"localhost:18550","request":"/eth/v1/builder/validators","http_method":"POST"}
{"lvl":"DBG","ts":"2024-08-13 12:19:23.428+00:00","msg":"REST request body has been sent","remote":"localhost:18550","request":"/eth/v1/builder/validators","size":160005,"http_method":"POST"}
{"lvl":"DBG","ts":"2024-08-13 12:19:23.962+00:00","msg":"Got REST response headers from remote server","remote":"localhost:18550","request":"/eth/v1/builder/validators","status":200,"http_method":"POST"}
{"lvl":"DBG","ts":"2024-08-13 12:19:23.962+00:00","msg":"Received REST response body from remote server","remote":"localhost:18550","request":"/eth/v1/builder/validators","contentType":"application/json","size":3}

mev-boost:

time="2024-08-13T12:19:23.961Z" level=info msg="http: POST /eth/v1/builder/validators 200" duration=0.557093 method=POST path=/eth/v1/builder/validators status=200

@yakimant
Copy link
Member

Keys (1600):
geth-07.ih-eu-mda1.nimbus.holesky.keys.txt

@yakimant
Copy link
Member

To get the Holesky ETH with Metamask:

  1. Switch to Holesky network: https://chainid.network
  2. Increase score 2+: https://passport.gitcoin.co
  3. Geth ETH: https://holesky-faucet.pk910.de

@yakimant
Copy link
Member

yakimant commented Aug 13, 2024

Hm, UI looks broken:
Screenshot 2024-08-13 at 15 19 51

@shaspitz, @techgangboss, did you see this before?

I will try this meanwhile:
https://docs.primev.xyz/developers/stake-validator-keys-manually

Hm, validator-registry requires 3.1 ETH per key.

@yakimant
Copy link
Member

Tested on a different brawser (Brave) - same issue.

@taylorjdawson
Copy link

@yakimant do you see anything in your console logs?

@yakimant
Copy link
Member

yakimant commented Aug 15, 2024

Indeed there is an error:

Object { details: "execution reverted", docsPath: undefined, metaMessages: undefined, shortMessage: "Execution reverted for an unknown reason.", name: "ExecutionRevertedError", version: "[email protected]", message: "Execution reverted for an unknown reason.\n\nDetails: execution reverted\nVersion: [email protected]", cause: InvalidInputRpcError }
page-c27b5514437b518b.js:1:15139
{
  "details": "execution reverted",
  "shortMessage": "Execution reverted for an unknown reason.",
  "name": "ExecutionRevertedError",
  "version": "[email protected]",
  "message": "Execution reverted for an unknown reason.\n\nDetails: execution reverted\nVersion: [email protected]",
  "cause": {
    "message": "Missing or invalid parameters.\nDouble check you have provided the correct parameters.\n\nURL: https://ethereum-holesky-rpc.publicnode.com\nRequest body: {\"method\":\"eth_estimateGas\",\"params\":[{\"data\":\"0xLONG_HEX_HERE\",\"from\":\"0x65d582e3c01c2b3cf14cd4dbee6335727c659f1d\",\"to\":\"0x5d4fC7B5Aeea4CF4F0Ca6Be09A2F5AaDAd2F2803\",\"value\":\"0x6a94d74f430000\"}]}\n\nDetails: execution reverted\nVersion: [email protected]"
  }
}

@yakimant
Copy link
Member

FYI @taylorjdawson

@taylorjdawson
Copy link

@yakimant Just deployed a fix 🔨let me know if have any more issues!

@yakimant
Copy link
Member

Thanks @taylorjdawson, it works!

Found another bug (non-blocking, with workaround).

Page appears with valid minimum stake value, but still with error:
Screenshot 2024-08-19 at 12 13 08

If I try to re-enter 0.0001 - it's fine (I used it to proceed):
Screenshot 2024-08-19 at 12 14 00

But if I try 0.0002 it has an issue again:
Screenshot 2024-08-19 at 12 14 04

@yakimant
Copy link
Member

Ok web tool finished (without success message).
So I suppose all setup it done, who can check it?
@tersec

yakimant added a commit that referenced this issue Aug 26, 2024
@yakimant
Copy link
Member

Everything was setup according to my understanding. No issues on the graphs.
Feel free to test and reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants