Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic control material choice. #328

Open
Pheotis opened this issue Feb 17, 2024 · 5 comments
Open

Deterministic control material choice. #328

Pheotis opened this issue Feb 17, 2024 · 5 comments
Labels
enhancement A suggested addition to the plugin. REWRITE This task/issue only applies to the rewritten version of the plugin (currently in ALPHA)

Comments

@Pheotis
Copy link

Pheotis commented Feb 17, 2024

Currently, activators and control surfaces (signs) are selected randomly. This is confusing.

Suggestion:

Choose materials based on biomes.

If in oak forest, use oak.
If in dark oak forest, use dark oak.
If in savannah, use accacia.
If underground, use stone.
If deep underground, use deepslate.

Related to, but not a duplicate of, #327

@Pheotis Pheotis added enhancement A suggested addition to the plugin. REWRITE This task/issue only applies to the rewritten version of the plugin (currently in ALPHA) labels Feb 17, 2024
@Pheotis Pheotis added this to the Development Cycle 1.0.0.17 milestone Feb 17, 2024
@Thorinwasher
Copy link

About biomes, there's like yeah, this many biomes. And that list will probably grow on each update.

@Thorinwasher
Copy link

Thorinwasher commented Feb 18, 2024

A thought just crossed my mind. Could actually make a scanner which uses NMS, reads data about each biome and stores it into a file which we can save as an internal file in Stargate. This would make everything automatic, which would decrease the need for maintenance for this feature. We can call the scanner StargateMiner or something.

There's also multiple different tree types for each biome, so should there be multiple button types, representing each tree type. Or do you think that we should have only one button type per biome?

@Pheotis
Copy link
Author

Pheotis commented Feb 20, 2024

I like the idea of doing this automatically, although needing to do it manually wouldn't be the end of the world; in fact, doing this for the forseeable future it would probably be quicker than needing to make some sort of nms tool.

While there are a load of biomes, the have more or less been gradually added (it's only specific, infrequent, updates that add a whole load of them). For now, I think I'll go ahead and manually make a table of these; if maintaining it becomes a pain, we can make a proper tool to automate this at a later date.

The other thing to consider is what to do for custom biomes. Mojang added support for it 3 years ago, and paper has stated an intention to eventually support it. For now, when an unknown biome is encountered, the easiest solution is probably to just default to something and complain to console.

@Thorinwasher
Copy link

For custom biomes, we can just resort to stone buttons

@Pheotis
Copy link
Author

Pheotis commented Jun 4, 2024

As an interim extension of the above, if a user chooses a sign material, the button should probably match that material.
Currently, button materials are randomly selected, which is confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A suggested addition to the plugin. REWRITE This task/issue only applies to the rewritten version of the plugin (currently in ALPHA)
Projects
Status: No status
Development

No branches or pull requests

2 participants