Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose native fetch in the browser #258

Closed
jmrog opened this issue Apr 5, 2021 · 1 comment
Closed

Expose native fetch in the browser #258

jmrog opened this issue Apr 5, 2021 · 1 comment
Assignees
Milestone

Comments

@jmrog
Copy link
Contributor

jmrog commented Apr 5, 2021

This library has relied on fetch-ponyfill for quite some time now. fetch-ponyfill uses XMLHttpRequest under the hood. That is generally okay, but it is not okay for clients (like Studio) that want access to response headers on query execution requests immediately (i.e., before the query results have finished streaming back), in order to (for example) enable killing a query from the same editor where you initiated it. For that, we need to use native fetch (at least given how fetch-ponyfill works right now). What's more, we really probably ought to use the native fetch when possible anyway; stardog.js does not support Internet Explorer, and fetch has been released in all modern browsers for some time now.

Ideally, we would do this as part of a refactor of stardog.js -- see, e.g., PR #200 -- but in the interest of speed and making incremental steps, it is probably okay to do it in some incremental (even if temporarily hacky) way.

Internally, this is related to VET-634.

@jmrog jmrog self-assigned this Apr 5, 2021
@jmrog jmrog added this to the v3.1.0 milestone Apr 8, 2021
@jmrog
Copy link
Contributor Author

jmrog commented Apr 8, 2021

Closed by #259.

@jmrog jmrog closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant