Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusion over what generation currently does #193

Open
leogagnon opened this issue Oct 18, 2024 · 0 comments
Open

Confusion over what generation currently does #193

leogagnon opened this issue Oct 18, 2024 · 0 comments

Comments

@leogagnon
Copy link
Contributor

Hi, I'm a bit confused by the comment that means, we intervene on every generated tokens! here https://github.com/stanfordnlp/pyvene/blob/31d3986e5b0b3d812eef8fdd0c39759fa1c1b58e/pyvene/models/intervenable_base.py#L2020C1-L2022C41. From what I understand setting unit_locations = {"base": 0} leads to intervening only on the first token, not on every generated token. Am I understanding right?

Also am I right in saying that intervening on the last generated token is not currently supported? This is how I interpreted this comment https://github.com/stanfordnlp/pyvene/blob/31d3986e5b0b3d812eef8fdd0c39759fa1c1b58e/pyvene/models/intervenable_base.py#L1989C1-L1991C29.

Thanks,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leogagnon