Updating CodeMirror

[sillylogger]

Right now we're on Version 5.31.0 released 20-10-2017. Upstream is now Version 5.46.0 released 22-04-2019. I ask because there is an issue with the preview for urls with underscores in them (opens an italics) and it seems like that is fixed in upstream.

Would you support a PR for this?

[moughxyz]

@sillylogger thanks for the heads up. I prefer to tackle these updates manually so I can test it at ease. PRs just create todos for me that sit in my inbox and force me to work on something when I'm already taken by something else, and cause me to ship in a more hurried pace. So let's treat this issue instead as my todo to investigate a Code Mirror update. About 5 other SN editors use Code Mirror as well, so those will need investigating as well.

[sillylogger]

Noted, let me know if I can help.

…

On Sun, May 12, 2019 at 9:55 PM, Mo Bitar < ***@***.*** > wrote: @ sillylogger ( https://github.com/sillylogger ) thanks for the heads up. I prefer to tackle these updates manually so I can test it at ease. PRs just create todos for me that sit in my inbox and force me to work on something when I'm already taken by something else, and cause me to ship in a more hurried pace. So let's treat this issue instead as my todo to investigate a Code Mirror update. About 5 other SN editors use Code Mirror as well, so those will need investigating as well. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( #7 (comment) ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AABJB5362MXHRSYY7BO7BALPVAVWRANCNFSM4HMJUGWA ).