-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deleting issue of blocks #58
Comments
sometimes it happens on change width or rendering to |
Can not reproduce the deleting error anymore. Could you folks, try to reproduce to get in a bouncing state with the blogs by deleting many blocks in a short time? |
I could reproduce it. See: |
It seem to happen when you delete the second instance of a block which is already there, so could be a wrong identifier (id) in a process to calculate the layout. the process is broken when deleting the block, the old blocks are then rendered and the deletion happens and the old blocks render and the deletion happens and the old blocks render .... and so on. recursion. add first link -> it appears |
Bildschirmaufnahme.2023-03-09.um.22.07.53.1.mp4 |
seems still not fixed, causes the site to crash. Ohne.Titel.mov |
Still working on it. I probably found the reason why al off that jiggling happens. Stay tuned |
Maybe unrelated, feel free to ignore / open another issue: Can you also debounce the query? Marc mentioned that every screen resolution change triggers a mutation on every single pixel. Should be debounced, like we have done it for the alias/link availability check or on some other places. We use lodash debounce for it. Explanation: We trigger DDOS Protection of Vercel / AWS with it and are then unable to send more Queries / Mutations. |
I fixed this locally. Because this is highly tight to #87 I didn't pushed it yet. |
No problem, sometimes it's harder and sometimes it's lighter :) You can do it, I know it for sure 🤗🤗 |
The text was updated successfully, but these errors were encountered: