Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleting issue of blocks #58

Open
Tracked by #145
NilsJacobsen opened this issue Feb 22, 2023 · 12 comments
Open
Tracked by #145

Fix deleting issue of blocks #58

NilsJacobsen opened this issue Feb 22, 2023 · 12 comments
Labels
groundwork This issues are needed to ship

Comments

@NilsJacobsen
Copy link
Member

  • if you delete blocks sometimes blocks snap around and onreaload it's fine again
@NilsJacobsen NilsJacobsen added the groundwork This issues are needed to ship label Feb 22, 2023
@NilsJacobsen NilsJacobsen added this to the Alpha Private Launch milestone Feb 22, 2023
@NilsJacobsen
Copy link
Member Author

sometimes it happens on change width or rendering to

NilsJacobsen added a commit that referenced this issue Feb 24, 2023
@NilsJacobsen NilsJacobsen self-assigned this Feb 27, 2023
@NilsJacobsen
Copy link
Member Author

Can not reproduce the deleting error anymore. Could you folks, try to reproduce to get in a bouncing state with the blogs by deleting many blocks in a short time?

@felixhaeberle
Copy link
Contributor

I could reproduce it. See:

https://www.loom.com/share/aab155c06cf04fd98eff4ac96c0d4849

@felixhaeberle
Copy link
Contributor

It seem to happen when you delete the second instance of a block which is already there, so could be a wrong identifier (id) in a process to calculate the layout.

the process is broken when deleting the block, the old blocks are then rendered and the deletion happens and the old blocks render and the deletion happens and the old blocks render .... and so on. recursion.

add first link
add second link
delete second link

-> it appears

@felixhaeberle
Copy link
Contributor

Bildschirmaufnahme.2023-03-09.um.22.07.53.1.mp4

@NilsJacobsen
Copy link
Member Author

image

I'm pretty sure this caused the issue:D the rerendering caused the store to fuck up.

NilsJacobsen added a commit that referenced this issue Mar 10, 2023
@felixhaeberle
Copy link
Contributor

seems still not fixed, causes the site to crash.

Ohne.Titel.mov

@felixhaeberle
Copy link
Contributor

Bildschirm­foto 2023-03-11 um 02 03 58

Bildschirmaufnahme.2023-03-11.um.02.03.33.mov

@felixhaeberle felixhaeberle mentioned this issue Mar 14, 2023
20 tasks
@NilsJacobsen
Copy link
Member Author

Still working on it. I probably found the reason why al off that jiggling happens. Stay tuned

@felixhaeberle
Copy link
Contributor

felixhaeberle commented Mar 14, 2023

Maybe unrelated, feel free to ignore / open another issue: Can you also debounce the query? Marc mentioned that every screen resolution change triggers a mutation on every single pixel.

Should be debounced, like we have done it for the alias/link availability check or on some other places. We use lodash debounce for it.

Explanation: We trigger DDOS Protection of Vercel / AWS with it and are then unable to send more Queries / Mutations.

@NilsJacobsen
Copy link
Member Author

I fixed this locally. Because this is highly tight to #87 I didn't pushed it yet.
Still working on it, cause it's mind fuck. I will get that endless done guys I swear.

@felixhaeberle
Copy link
Contributor

No problem, sometimes it's harder and sometimes it's lighter :) You can do it, I know it for sure 🤗🤗

@NilsJacobsen NilsJacobsen removed their assignment Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
groundwork This issues are needed to ship
Projects
None yet
Development

No branches or pull requests

2 participants