-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Signer Alongside Node #57
Open
BowTiedDevOps
wants to merge
29
commits into
main
Choose a base branch
from
feat/release-signer-alongside-node
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wileyj
reviewed
Dec 11, 2024
wileyj
reviewed
Dec 11, 2024
wileyj
reviewed
Dec 11, 2024
wileyj
reviewed
Dec 11, 2024
wileyj
reviewed
Dec 11, 2024
wileyj
reviewed
Dec 11, 2024
wileyj
reviewed
Dec 11, 2024
wileyj
reviewed
Dec 11, 2024
wileyj
reviewed
Dec 11, 2024
wileyj
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! some minor changes (mostly cosmetic) but otherwise it looks ready to merge.
we'll want to cooridinate with the stacks-core PR on when to merge though, else it may break some workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to create a signer release every time there is a core release happening, with the tag set as
<core_release>.0
.This PR also moves most of the release workflow out of
stacks-core
and intoactions
repository such that on subsequent changes to the release process, we can easier adjust the workflows without the need ofstacks-core
pull requests.I've also implemented
latest
docker image tags on non-RC releases and removed thesigner-
word from the signer version tag as it was redundant.Example workflows (tests commented out for quicker workflow runs, but they are unaffected by these changes):
4.0.0.0.0
andsigner-4.0.0.0.0.0
releases): https://github.com/BowTiedDevOps/stacks-core/actions/runs/11963198211signer-4.0.0.0.0.1
release): https://github.com/BowTiedDevOps/stacks-core/actions/runs/11963781406signer-4.0.0.0.0.2-rc1
release, used to test that docker imagelatest
doesn't update on RC builds): https://github.com/BowTiedDevOps/stacks-core/actions/runs/11963969804Useful Links:
Binaries Version Check:
Docker Images Version Check: