feat(checks): remove checks for cpu and memory limits #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janisz
requested changes
Feb 5, 2024
| @@ -48,9 +48,6 @@ func init() { | |||
| if p.RequirementsType == "request" || p.RequirementsType == "any" { | |||
| process(&results, container.Name, "request", container.Resources.Requests.Memory(), lowerBoundBytes, upperBoundBytes) | |||
| } | |||
| if p.RequirementsType == "limit" || p.RequirementsType == "any" { | |||
| process(&results, container.Name, "limit", container.Resources.Limits.Memory(), lowerBoundBytes, upperBoundBytes) | |||
| } | |||
There was a problem hiding this comment.
I think we should not touch templates and only change the check https://github.com/stackrox/kube-linter/pull/712/files#diff-98bbd8809c1b605e233765c4d90b25a932af5d2545dc495de58774f3f3a7c0b2R11
| remediation: >- | ||
| Set memory requests and limits for your container based on its requirements. | ||
| Set memory requests for your container based on its requirements. |
There was a problem hiding this comment.
Suggested change
| Set memory requests for your container based on its requirements. | |
| Set memory limits for your container based on its requirements. |
According to the design we need limits for mem and requests for CPU.
|
@cwimmer ping |
|
Closing in favor of #734 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #694
Fixes: #695
This PR removes the checks for cpu and memory limits. It also includes updates to documentation which refer to these checks.