Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unset-memory-requirements check #695

Open
janisz opened this issue Jan 23, 2024 · 0 comments
Open

Change unset-memory-requirements check #695

janisz opened this issue Jan 23, 2024 · 0 comments

Comments

@janisz
Copy link
Collaborator

janisz commented Jan 23, 2024

Currently the unset-memory-requirements requires both requests and limits. This is redundant as request if not set will be copied from limits. The memory differs from CPU as with not enough CPU the container will slow down while with missing memory it will be killed. That's why requirements and limits should be set to same value.

The change should happen in check template definition

As well as in the related tests:
@test "unset-memory-requirements" {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant