Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flavor based reservation #1

Draft
wants to merge 66 commits into
base: master
Choose a base branch
from
Draft

Flavor based reservation #1

wants to merge 66 commits into from

Conversation

JohnGarbutt
Copy link
Member

Opened this just so see the changes really.

priteau and others added 9 commits March 8, 2022 22:39
@priteau
Fix context unit test
a1ddb0c 
This was caused by the bump of oslo.context to 4.1.0 [1], which includes
removal of the deprecated argument tenant from RequestContext [2].

Replace tenant key in the context object by project_id to fix the lower
constraints job, which is still using oslo.context 2.22.0.

[1] https://review.opendev.org/c/openstack/requirements/+/829599
[2] https://review.opendev.org/c/openstack/oslo.context/+/815938

Change-Id: I281ffa4f6fc29c691da48a792bc203818e334d9d
(cherry picked from commit 8af178c)
@openstackadmin @priteau
Update .gitreview for stable/yoga
936afa4 
Change-Id: I103cd8f850488e6a634dd427c41ee1fe7c4f1748
@openstackadmin @priteau
Update TOX_CONSTRAINTS_FILE for stable/yoga
591b4ac 
Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.

Until the requirements repository has as stable/yoga branch, tests will
continue to use the upper-constraints list on master.

Change-Id: I78b12f832750c144752f8138e4283b1735367280
@priteau
Switch to stestr
e61d4cf 
According to Openstack summit session [1],
stestr is maintained project to which all Openstack projects should migrate.
Let's switch to stestr as other projects have already moved to it.

[1] https://etherpad.openstack.org/p/YVR-python-pti

Change-Id: I9d22be39bec67fc17841367a0ef0ac439143af6c
(cherry picked from commit aa2a14a)
@priteau
Fix references to start and end dates
51aed25 
The lease attributes are called start_date and end_date, not start_time
and end_time.

Change-Id: I77fb08a3811ed1445e31b3552ca23d5bfc43a07d
(cherry picked from commit bd6469d)
@priteau
Synchronise tox.ini with changes from other branches
8e0e6c3 
In other maintained branches, the blazar installation was removed in [1]
and then restored in [2] to fix an issue with generated docs. This was
not done on stable/yoga, so this change synchronises tox.ini with
these changes made on other branches.

[1] Ic55dba0038a2209e9fb291a604a5c1da57607e1e
[2] I28d06ae31c4cf44d010e0892a094138112b08641

Change-Id: Ibc7c7751dd8769d3eb5c73c3b9a82b383c6d5630
@priteau @yoctozepto
[CI] Move queue setting to project level
590730a 
Per [1].

[1] http://lists.zuul-ci.org/pipermail/zuul-discuss/2022-May/001801.html

Change-Id: I34934eefee6c0cd3b999fa028e6697d1c5e8476a
(cherry picked from commit b6ec560)
@JohnGarbutt
WIP: Record placement resources and traits for hosts
7f02440 
When we add a host, go to placement and collect the resource
class and trait information.

We can then use this to better filter hosts via flavors that
have advanced requests in them, like PCPUs and Baremetal flavors.
Note we can also find out about allocation raitos from
placement.

Change-Id: I5821fcf868013de0b27accb893b6bc2c611f86d1
@JohnGarbutt
WIP: Option to use flavor_id to request reservation
1c5b01b 
Instead of creating custom RAM and CPU ratios, we offer the option
to reserve a specific number of a pre-defined flavor.

When you specify the flavor, we still allow amount and affinity,
but we ignore resource_properties, vcpus, memory_mb and disk_gb,
as these are all taken from the flavor instead.

TODO: should we have the option to block non-flavor based instance
reservation via a configuration option?

Change-Id: I9803a7ee21011584263c83fb982d403fa605ae34
@JohnGarbutt
HACK: ignore when servers existing on host
1e28e30 
Change-Id: I5805c4cab75b5d1b7f6077950d07197e7df29fe3
@JohnGarbutt
Hack: remove host with instances
d98667f 
Change-Id: Iae5bbc54a5def46356b3295200b5d195e63c27b0
@JohnGarbutt
Fix up reference to ComputeHostResourceInventory
2524dca 
Change-Id: I4c09c627b06eecb312dec444d316d8e60f80920d
@JohnGarbutt
Attempt adding alembic migration
b20e866 
But we seem to be missing the new tables!

Change-Id: I620dcf6a1d9b6a3dbdd25da0b4440fbe3d049ed2
@JohnGarbutt
Fill in missing resource details
a138dc1 
Change-Id: I47a99f2253adbc6f7dba6460843d860410995c81
@JohnGarbutt
Fetch traits for compute node
eb22432 
Change-Id: I4a7713e4eea6e0a17f464311519f75f94e603e97
@JohnGarbutt
Add traits into db when adding a host
8601aec 
Change-Id: I99e1353a30f35393a3ff1fc3136c7415dfa491c3
@JohnGarbutt
Add missing tables
3e1230a 
Change-Id: I03b239fe986fb7272b8c6482f5300eb2471d597a
@JohnGarbutt
Remote dead pci_alias code
cae9021 
Change-Id: I226d61741041b777e65e73d02e5b726f7b2b66b0
@JohnGarbutt
Comment out missing keys for now
37febfa 
Change-Id: I548229b1b91cfaf8e3f5a3d79548eb09997bab95
@JohnGarbutt
hack to get flavor_id
57f6955 
Change-Id: I5ab96b7cdb2953c28e3b8058dbea0dd1a598183d
@JohnGarbutt
Fix up get flavor_id hack
1c88acf 
Change-Id: I6629d3f88ac769769793d6480e480bde1732fed7
@JohnGarbutt
Fix client name to flavors
b4b5cb4 
Change-Id: I5a4561be315e23ed3710ae21584276874604a908
@JohnGarbutt
HAck to get extra specs
5efbdda 
Change-Id: If95168bb5b13af017f9f1e64a84cf84afcefac77
@JohnGarbutt
Start to use extra specs
ba57e8d 
Change-Id: I541b5f37488d9e7112f8723fa61089af649c4875
@JohnGarbutt
Add missing _create_resources param
bbce89f 
Change-Id: If5e845822b68dc100548410e5b7a94b722df22e0
@JohnGarbutt
HACK: stop creating server group!
a250bdd 
Change-Id: I7001569fa2cd6345522bebb29d845933c948ca65
@JohnGarbutt
Hack up resource_inventory to parse empty string
5fa95e3 
Change-Id: I2e65b6c9ded7a29ed871e368990d785912c476d7
@JohnGarbutt
Fix server_group workaround
ddeb67a 
Change-Id: I6944eba6171ea67e082733afb47197b0508398e4
@JohnGarbutt
Hack to let flavor get created
581693b 
Change-Id: I7338d11ed416d038b8ee44314ef78239cc764aad
@JohnGarbutt
Remove exception hack
3f8127a 
Change-Id: Iff5fcf502cd3555e32cb17bf469cc92c00e3cb75
@JohnGarbutt
Add extra info into instance reservation db
7961d5b 
Change-Id: I3c1e67a473be4f008185ba5521facc949a834c0f
@JohnGarbutt
Copy across extra specs to flavor
4efc30a 
Change-Id: I16e28120db151e73d4896f7a038ad52ff45ab673
@JohnGarbutt
Add debug logs for candiate hosts
12a97e2 
Change-Id: Ie65aa7d5a09b0d07858e57c616215bef890d81b6
@JohnGarbutt
Hack to skip CPUs for slots
0b635f1 
Change-Id: Ieb3a099c09071c029b86ed78729130d31e46cc2f
@JohnGarbutt
Debug to check we get resource inventory
f20dfd9 
Change-Id: I8538def10e14b2b1c2cd5377aa224bba9a7b0116
@JohnGarbutt
Rewrite get_hosts_list to use resource_inventory
404c019 
Move to general list of resources, rather than just cpu,ram,disk.

Change-Id: I0d67cc4589bfc856eca33c37bfde92ebc097b92a
@JohnGarbutt
Fix up resource_usage_by_event
aba720f 
Change-Id: I8894ab6e927fbb891138dbc61fe78c31e89dcc7f
@JohnGarbutt
Improve debug for get_hosts_list
a9063ff 
Change-Id: I5d807fc8206d32a9ce43d5a8fa3a4b005881d584
@JohnGarbutt
Get more debug from max_usages
9dd840a 
Change-Id: I0951332456e8926e942f88464a432b3ac0cb9f76
@JohnGarbutt
Add more debug
7b16e06 
Change-Id: I6640599985d579d9164132b1277b831b6a4d04a8
@JohnGarbutt
Don't error if not requested anything
687e32e 
Change-Id: I4aa6e32ecd0d844b18f456d0951f99752a44a134
@JohnGarbutt
Skip zero vpus better
59762b1 
Change-Id: Ie8b3f8913c5bd3996416f0b66ebe325f922c572d
@JohnGarbutt
Move instance reservation to use placement aggregates
3991f92 
In the hope it helps with ironic nodes

Change-Id: I433ddf9c4085fee545f75442a2e306a628653ced
@JohnGarbutt
Move create_computehost to use placement aggregates
dc5938a 
Change-Id: Ic13057d21bfaad76e39a155c7b1889bd4279525d
@JohnGarbutt
Fix getting aggregate uuid
9d22ba7 
Change-Id: If2c6819fc33abdc16f50943bb952cabea907007f
@JohnGarbutt
Add missing arg for _put_rp_aggregates
d7d5950 
Change-Id: I68c640b864f0bb910c91948ab45913018ff84c09
@JohnGarbutt
Try to fix up remove_host
4e8aa5a 
Change-Id: Iac99a4a39e4d28d3202d4f7dfd77dfe675acbd28
@JohnGarbutt
Add info on host filters
8be74a7 
Change-Id: I27e7ee034e2777a42d14493ef03e1dad6c3c57a7
@JohnGarbutt
Get more info
44bdbee 
Change-Id: Ic1f1a32decbd9de46dda4ffd564ba1ceb7d4722f
@JohnGarbutt
Fixup finding extra spec resource requests
3bc0254 
Change-Id: I597f993a85cbed718b13d1340d9ad21ea9b24682
@JohnGarbutt
Fix up the value of extra resources
9368740 
Change-Id: I0411ffa6d2a6595a5ca74d6cf9bdb4ebd7346989
@JohnGarbutt
Nope, try put custom resources in the inventory
51582a0 
Change-Id: I5d0b817c289c444c47dcde04332e266f37e6dd1d
@JohnGarbutt
Fix up resource class filtering
ac29143 
Change-Id: I79e88a943e2c91d25173b9757b7de4be07a5556f
@JohnGarbutt
Fix up use of add/remove compute host
4411e62 
Change-Id: I1c57794e8dd12266fe95e5ed3a7c0e18b05deb10
@JohnGarbutt
Fix creating lease as non-admin user
553240d 
Change-Id: Ia4db9d7ca4107b09d26302b2594c5c1953ba7a46
@JohnGarbutt
Fix up nova client admin creds
ced262b 
Change-Id: Ia828115c26fddf8af41523f713c1f23b17240168
@JohnGarbutt
Merge remote-tracking branch 'origin/master' into flavor-based-reserv…
5a2efa2 
…ation

Change-Id: Ia363b2d459fb1c711924bf27a7e77601a2f67647
@JohnGarbutt
Revert local tox.ini changes
ce25e53 
Change-Id: I6bac2986d3530c0076f4c068f17104b31f19c46c
@JohnGarbutt
Copy link
Member Author

Note, I still need to extract the logic around ironic nodes being added into placement aggregates, to support baremetal flavors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnGarbutt @priteau @openstackadmin