Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerals for Arabic/Urdu Scripts #45

Open
yourfluffyface opened this issue Mar 27, 2019 · 6 comments
Open

Numerals for Arabic/Urdu Scripts #45

yourfluffyface opened this issue Mar 27, 2019 · 6 comments
Assignees

Comments

@yourfluffyface
Copy link

Hi,

I'm using this keyboard for an Urdu language related project and it's great as far as I've tested it. However, as the numerals for most Eastern scripts are different, I updated my .klc file to incorporate Urdu numbers. I'm still having trouble with the direction the numbers appear because , currently, the numbers go from LTR instead of RTL (similar to the rest of the script).

Any help would be appreciated.
Thanks!

urduUpdated.zip

@srm985 srm985 self-assigned this Mar 27, 2019
@srm985
Copy link
Owner

srm985 commented Mar 27, 2019

Greetings! I'll have a look. So the expected and normal behavior is that while writing in Urdu the numbers can be inline and will flow RTL?

@yourfluffyface
Copy link
Author

yourfluffyface commented Mar 28, 2019 via email

@srm985
Copy link
Owner

srm985 commented Mar 28, 2019

So if I understand, there is no issue? Is that correct?

What about the update numerals? Does the current Urdu layout have the wrong numerals? Should I replace them with yours?

@yourfluffyface
Copy link
Author

yourfluffyface commented Mar 28, 2019 via email

@srm985
Copy link
Owner

srm985 commented Mar 31, 2019

I have a couple of questions - perhaps you can help me understand them so I can create better Urdu support. Does Urdu always use the numerals in your updated file or does it ever use 0-9? I am trying to determine if I should replace the current Urdu file with yours or create a second one which is yours.

As far as LTR vs RTL, I guess Urdu is RTL so I'll be adding a check for that.

And finally, on the enter key, you are saying you wrote a custom callback to insert a new line but it wasn't placing the cursor correctly?

Edit
Oh and one more question, how does it work when entering Urdu numerals into an input field which only allows numbers? Does this work or do you have to use 0-9?

@yourfluffyface
Copy link
Author

yourfluffyface commented Apr 3, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants