Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Api, FieldMask, SourceContext, and Type from protobuf's `.proto' files. #2976

Open
oldergod opened this issue Jun 6, 2024 · 5 comments

Comments

@oldergod
Copy link
Member

oldergod commented Jun 6, 2024

No description provided.

@jianchaoxudd
Copy link

hey @oldergod ,

The field mask you in this issue is the google.protobuf.fieldmask? https://github.com/protocolbuffers/protobuf/blob/main/src/google/protobuf/field_mask.proto

@oldergod
Copy link
Member Author

oldergod commented Jun 7, 2024

Yes, all types listed are from .proto files within https://github.com/protocolbuffers/protobuf/tree/main/src/google/protobuf

@jianchaoxudd
Copy link

Yes, all types listed are from .proto files within https://github.com/protocolbuffers/protobuf/tree/main/src/google/protobuf

Nice! Do you have timeline for FieldMask support at least?

@oldergod
Copy link
Member Author

oldergod commented Jun 7, 2024

Not at all. They should all already be working but you'll run into troubles if you have a codebase using Wire and protoc alongside each other. Those types will be generated by both and conflict.

@jianchaoxudd
Copy link

I see. We are internally using Wire-Runtime to parse protobuf file, but there is no ProtoType.FieldMask yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants