Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZipFileSystem doesn’t honor local time zone on Kotlin/Native #1440

Open
swankjesse opened this issue Feb 22, 2024 · 0 comments
Open

ZipFileSystem doesn’t honor local time zone on Kotlin/Native #1440

swankjesse opened this issue Feb 22, 2024 · 0 comments

Comments

@swankjesse
Copy link
Member

The DOS date format assumes file times use the local machine’s zone offsets, but we’re using UTC only.

Could fix by taking a dependency on kotlinx-datetime once that library reaches 1.0.

Could fix on Windows and Apple platforms by finding native APIs for time zone mapping. I’m unsure about whether such APIs are available without dependencies on Linux.

The impact of this is low because ZIP files may also include a date stamp in the extended format which doesn’t have this limitation. I haven’t yet done the research to learn how common that extension is among the .zip files that users are likely to encounter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant