Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Java 8 IT failure #425

Open
JakeWharton opened this issue Jul 21, 2014 · 6 comments
Open

Java 8 IT failure #425

JakeWharton opened this issue Jul 21, 2014 · 6 comments

Comments

@JakeWharton
Copy link
Collaborator

The post-build script did not succeed. Build output did not contain expected error text:
    "@Inject is not valid on a class: test.TestApp"
Build Output:
        [ERROR] COMPILATION ERROR : 
        [ERROR] /home/travis/build/square/dagger/compiler/target/it/inject-on-class/src/main/java/test/TestApp.java:[20,1] annotation type not applicable to this kind of declaration
        [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project method-injection: Compilation failure
        [ERROR] /home/travis/build/square/dagger/compiler/target/it/inject-on-class/src/main/java/test/TestApp.java:[20,1] annotation type not applicable to this kind of declaration
@JakeWharton
Copy link
Collaborator Author

I saw this locally and just added Java 8 to .travis.yml to verify (and for future changes).

@cgruber
Copy link
Collaborator

cgruber commented Aug 5, 2014

Why would @Inject not be valid. Did something in 8 change about annotation declarations that I missed?

@JakeWharton
Copy link
Collaborator Author

The two annotation-related features that were added were annotations on types and support for repeating annotations.

@cgruber
Copy link
Collaborator

cgruber commented Aug 5, 2014

Yeah, but that increases the places annotations are valid. I am not clear on why annotations would suddenly become invalid.

@JakeWharton
Copy link
Collaborator Author

The test is failing because of the absence of a failing compile. The test wants the build to fail but it erroneously succeeds.

@cgruber
Copy link
Collaborator

cgruber commented Aug 5, 2014

Oh my god I'm blind today. Right.

tbroyer pushed a commit to tbroyer/dagger that referenced this issue Aug 25, 2016
Move Analytics file into the right place
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants