Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To avoid maintain sqlflow.proto file in the separated repo #69

Open
Yancey1989 opened this issue Jun 19, 2019 · 6 comments
Open

To avoid maintain sqlflow.proto file in the separated repo #69

Yancey1989 opened this issue Jun 19, 2019 · 6 comments

Comments

@Yancey1989
Copy link
Collaborator

Yancey1989 commented Jun 19, 2019

Mabe adds the sqlflow repo as the submodule of pysqlflow is a good way.

@Yancey1989 Yancey1989 changed the title Using the sqlflow.proto in the sqlflow repo to avoid maintain the proto file in the separated repo To avoid maintain sqlflow.proto file in the separated repo Jun 19, 2019
@tonyyang-svail
Copy link
Collaborator

tonyyang-svail commented Jun 20, 2019

I believe it is better to have a little duplication than importing a huge library for a single file. :) ref

@typhoonzero
Copy link
Collaborator

Just for discussion: #70 (comment)

@LiuGuodong1314
Copy link

How can I run extended SQL using pysqlflow

@Yancey1989
Copy link
Collaborator Author

Hi @LiuGuodong1314 , you can use the all-in-one Docker image, please go to https://github.com/sql-machine-learning/sqlflow/blob/develop/doc/demo.md

@LiuGuodong1314
Copy link

Hi @Yancey1989,
I execute
"SELECT * FROM iris.train TRAIN DNNClassifier WITH n_classes = 3 COLUMN sepal_length, sepal_width, petal_length, petal_width LABEL class INTO sqlflow_models.my_dnn_model"
in python language using pysqlflow, but it throws "runExec failed: Error 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version ...."
How can I manage it?

@Yancey1989
Copy link
Collaborator Author

It seems that the extended SQL should be ... WITH n_classes = 3, hidden_units = [10, 20] COLUMN ... ? And your problem is not related to this issue, maybe you can recreate an issue at https://github.com/sql-machine-learning/sqlflow/issues if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants