Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pylint as sub-module #13

Open
DanielNoord opened this issue Apr 21, 2022 · 6 comments
Open

Add pylint as sub-module #13

DanielNoord opened this issue Apr 21, 2022 · 6 comments

Comments

@DanielNoord
Copy link

Hi,

We have been hard at work integrating the content of this wonderful project into the main pylint project. Progress can be viewed here:
pylint-dev/pylint#5953

I was wondering, would you be willing to add pylint as a sub-module to this project? If we were to do so we would be able to get some of the data from the pylint documentation data instead of getting it from this project. That would remove some of the duplication that will eventually be created between both projects. It will also direct any efforts towards improving examples or documentation to one place instead of across both projects.
The data structure of our new data is explained in the mentioned issue and should be fairly trivial to integrate into the project after pylint has been added as sub-module.

I'd be happy to create a PR to do this!

@sprytnyk
Copy link
Owner

Hi Daniel, if this help pylint then I surely will be glad to do this

@sprytnyk
Copy link
Owner

Hi @DanielNoord
So do you want to add pylint as a git submodule or inside setup.py?

@DanielNoord
Copy link
Author

Sorry, I haven't gotten round to this.

Currently using setup.py won't work as we don't include our documentation in our packages. However, we might be able to create a pylint[documentation] package which does include this. I will investigate if that is a possibility!

@sprytnyk
Copy link
Owner

If you want we can migrate the lib to Python Code Quality Authority. Anyway, I'm busy fighting russians in Ukraine, moreover, not cable of contributing to open source, and doing my work as it used to be before the 24th of February 2022. Let me know what you think about it, so maybe it will give you more flexibility while copying over documentation, etc.

@DanielNoord
Copy link
Author

Anyway, I'm busy fighting russians in Ukraine

Stay safe and best of luck!

moreover, not cable of contributing to open source, and doing my work as it used to be before the 24th of February 2022. Let me know what you think about it, so maybe it will give you more flexibility while copying over documentation, etc.

Where still working on writing the examples for all the messages that are missing. I don't expect that process to be done in the short term future so until then this is not a priority for us I think. I'll let you know when we are done or nearing completion and perhaps I can make a PR then!

@sprytnyk
Copy link
Owner

Thank you @DanielNoord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants