New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presentations are not really validated in 0.8.0 #553

Open

ivan770 opened this issue Jun 26, 2024 · 0 comments

Assignees

Contributor

ivan770 commented Jun 26, 2024

It seems that currently JSON presentations are not being validated:

ssi/crates/claims/crates/vc/src/syntax/json/presentation/mod.rs

Lines 92 to 96 in b9e988d

    
           impl<C, E, P> Validate<E, P> for JsonPresentation<C> { 
        
               fn validate(&self, _: &E, _: &P) -> ClaimsValidity { 
        
                   Ok(()) 
        
               } 
        
           }

At the very least, it's possible to loop through all credentials and verify that they are still valid.

timothee-haudebourg self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment