Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ed25519VerificationKey2018 doesn't support publicKeyJwk apparently #517

Open
vdods opened this issue Jun 29, 2023 · 1 comment
Open

Ed25519VerificationKey2018 doesn't support publicKeyJwk apparently #517

vdods opened this issue Jun 29, 2023 · 1 comment

Comments

@vdods
Copy link
Contributor

vdods commented Jun 29, 2023

The pub key is meant to be publicKeyBase58; see https://github.com/digitalbazaar/ed25519-signature-2018-context/blob/master/contexts/ed25519-signature-2018-v1.jsonld#L25

For context, transmute-industries/verifiable-data#241
@sbihel
Copy link
Member

sbihel commented Jun 30, 2023

Considering we support all public key fields, I wouldn't expect it to be a painful breaking change. But maybe we should directly move directly to JsonWebKey2020 and Multikey?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vdods @sbihel