Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify proof-embedded capability delegation RDF consistency #437

Open
clehner opened this issue May 13, 2022 · 0 comments
Open

Verify proof-embedded capability delegation RDF consistency #437

clehner opened this issue May 13, 2022 · 0 comments
Labels
bug Something isn't working spec-alignment Changes needed to align with specification updates

Comments

@clehner
Copy link
Contributor

clehner commented May 13, 2022

The verify_proof_consistency function (added in #241) calls match_list_property to check that a proof object's JSON(-LD) corresponds to its RDF data:

ssi/src/vc.rs

Lines 2269 to 2276 in 3fc36d8

graph_ref.match_list_property(
proof_id,
"https://w3id.org/security#capabilityChain",
proof
.property_set
.as_ref()
.and_then(|cc| cc.get("capabilityChain")),
)?;

But this expects that the capabilityChain proof property if present contains an array of URIs (IRIs). The check fails when an embedded delegation object exists in the array. To allow embedded delegations in the capabilityChain array, the check in verify_proof_consistency needs to be relaxed or improved to handle this case.

@clehner clehner added bug Something isn't working spec-alignment Changes needed to align with specification updates labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spec-alignment Changes needed to align with specification updates
Projects
None yet
Development

No branches or pull requests

1 participant