Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerHeadersDsl doesn't allow addition of custom ServerHttpHeadersWriter #16009

Closed
vonZeppelin opened this issue Oct 29, 2024 · 1 comment · Fixed by #16136
Closed

ServerHeadersDsl doesn't allow addition of custom ServerHttpHeadersWriter #16009

vonZeppelin opened this issue Oct 29, 2024 · 1 comment · Fixed by #16136
Assignees
Labels
in: config An issue in spring-security-config type: enhancement A general enhancement

Comments

@vonZeppelin
Copy link

Expected Behavior
It should be possible to add a custom ServerHttpHeadersWriter with Kotlin DSL, something like

http {
    headers {
        writer {
            StaticServerHttpHeadersWriter.builder()
                .header(..., ...)
                .build()
        }
    }
}

Current Behavior
Kotlin ServerHeadersDsl class doesn't provide a way to add custom ServerHttpHeadersWriters.

Context
A workaround is

http.headers { spec ->
    spec.writer(...)
}
@vonZeppelin vonZeppelin added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Oct 29, 2024
@evgeniycheban
Copy link
Contributor

Hi, @jzheaux since gh-16002 was closed due to being fixed by spring-framework team, I could take this instead.

@jzheaux jzheaux added in: config An issue in spring-security-config in: web An issue in web modules (web, webmvc) and removed status: waiting-for-triage An issue we've not yet triaged in: web An issue in web modules (web, webmvc) labels Nov 8, 2024
evgeniycheban added a commit to evgeniycheban/spring-security that referenced this issue Nov 20, 2024
evgeniycheban added a commit to evgeniycheban/spring-security that referenced this issue Nov 20, 2024
evgeniycheban added a commit to evgeniycheban/spring-security that referenced this issue Dec 9, 2024
evgeniycheban added a commit to evgeniycheban/spring-security that referenced this issue Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants