Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carrier thread be suspended by synchronized in RemoteJWKSet #15866

Closed
me0106 opened this issue Sep 30, 2024 · 3 comments
Closed

carrier thread be suspended by synchronized in RemoteJWKSet #15866

me0106 opened this issue Sep 30, 2024 · 3 comments
Assignees
Labels
status: duplicate A duplicate of another issue type: bug A general bug

Comments

@me0106
Copy link

me0106 commented Sep 30, 2024

RemoteJWKSet use synchronized for synchronization.
But this will suspend the carrier thread.
In some specific situations, it may cause the server to hang:

single carrier thread.(Single core CPU). And call itself to retrieve jwk.

RemoteJWKSet is deprecated. Should we replace it with JwkSourceBuilder?

SpringBoot: 3.3.1
Java: Temurin-21.0.4+7

image
image

@me0106 me0106 added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Sep 30, 2024
@rwinch
Copy link
Member

rwinch commented Oct 2, 2024

Thank you for the report. Would you be interested in submitting a pull request to replace RemoteJWKSet?

@rwinch rwinch self-assigned this Oct 2, 2024
@franticticktick
Copy link
Contributor

Hi @rwinch, in this issue we need to replace the old jose api with a new one. This is not a very simple issue, for example JWKSetCache is now deprecated, and it is needed for JwkSourceBuilder. I can think about how to solve this issue.

@rwinch rwinch added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 11, 2024
@rwinch
Copy link
Member

rwinch commented Dec 11, 2024

Closing as duplicate of gh-16251

@rwinch rwinch closed this as completed Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Development

No branches or pull requests

3 participants