Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null handling to sort query parameters #3153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add null handling to sort query parameters #3153

wants to merge 1 commit into from

Conversation

pheyken
Copy link

@pheyken pheyken commented Sep 13, 2024

Closes #3152

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 13, 2024
@pheyken pheyken mentioned this pull request Sep 13, 2024
Open
@mp911de mp911de self-assigned this Sep 16, 2024
rodrigorodrigues pushed a commit to rodrigorodrigues/spring-data-commons that referenced this pull request Sep 16, 2024
@odrotbohm
Properly emit domain events from calls to saveAll(…).
5f64564 
We now treat CrudRepository.saveAll(…) properly by unwrapping the given *Iterable*. This previously already worked for collections handed into the method but not for types only implementing Iterable directly (like Page or Window).

Fixes spring-projects#3153.
Related tickets spring-projects#2931, spring-projects#2927.
@pheyken pheyken marked this pull request as ready for review September 23, 2024 05:26
@pheyken
Copy link
Author

pheyken commented Nov 15, 2024

Hey @mp911de, thank you so much for picking this up!

Is there anything I might be able to help you with to get this rolling? Do you by chance have an update on when / how this PR might move forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow specifying null handling for 'sort' query params as well as setting a default
3 participants
@pheyken @mp911de @spring-projects-issues