Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overload to ReactiveSortingRepository accepting a Limit parameter. #2923

Open
christophstrobl opened this issue Sep 7, 2023 · 4 comments
Open

Add overload to ReactiveSortingRepository accepting a Limit parameter. #2923

christophstrobl opened this issue Sep 7, 2023 · 4 comments
Assignees
@hwan33
Labels
type: enhancement A general enhancement

Comments

@christophstrobl
Copy link
Member 

Flux<T> findAll(Sort sort, Limit limit);
@mp911de
Copy link
Member

mp911de commented Sep 13, 2023

Also, FetchableFluentQuery and its reactive variant could benefit from a limit(Limit) overload.

@mp911de mp911de added the type: enhancement A general enhancement label Sep 13, 2023
@hwan33
Copy link

hwan33 commented Oct 10, 2023

hi @christophstrobl , I would like to work on this issue, can you assign it to me?

@christophstrobl
Copy link
Member Author

@hwan33 done - please make sure to read/follow our contributions guidelines. Thank you!

@christophstrobl christophstrobl added the status: waiting-for-feedback We need additional information before we can continue label Oct 10, 2023
@spring-projects-issues
Copy link

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues spring-projects-issues added the status: feedback-reminder We've sent a reminder that we need additional information before we can continue label Oct 17, 2023
@mp911de mp911de removed status: waiting-for-feedback We need additional information before we can continue status: feedback-reminder We've sent a reminder that we need additional information before we can continue labels Oct 17, 2023
hwan33 added a commit to hwan33/spring-data-commons that referenced this issue Oct 17, 2023
@hwan33
Add overload to ReactiveSortingRepository accepting a Limit parameter.
38663d1 
See spring-projects#2923
hwan33 added a commit to hwan33/spring-data-commons that referenced this issue Oct 17, 2023
@hwan33
Add unit test case.
81349a8 
See spring-projects#2923
hwan33 added a commit to hwan33/spring-data-commons that referenced this issue Oct 17, 2023
@hwan33
Add apache license to test file.
8857b40 
See spring-projects#2923
hwan33 added a commit to hwan33/spring-data-commons that referenced this issue Oct 17, 2023
@hwan33
Add overload to ReactiveSortingRepository accepting a Limit parameter.
73911ef 
See spring-projects#2923
hwan33 added a commit to hwan33/spring-data-commons that referenced this issue Oct 18, 2023
@hwan33
Add overload to ReactiveSortingRepository accepting a Limit parameter.
d918f39 
See spring-projects#2923
@hwan33 hwan33 mentioned this issue Oct 18, 2023
Closed
hwan33 added a commit to hwan33/spring-data-commons that referenced this issue Oct 18, 2023
@hwan33
Refactored code for enhanced readability.
312363a 
Related spring-projects#2923
hwan33 added a commit to hwan33/spring-data-commons that referenced this issue Oct 19, 2023
@hwan33
Fix incorrect argument in test code.
986f604 
replace `Limit.unlimited()` with `Limit.of(Integer.MAX_VALUE)`

Related spring-projects#2923
hwan33 added a commit to hwan33/spring-data-commons that referenced this issue Oct 19, 2023
@hwan33
Remove whitespace.
227532d 
Related spring-projects#2923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hwan33 hwan33

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add overload to ReactiveSortingRepository accepting a Limit parameter. hwan33/spring-data-commons
4 participants
@mp911de @christophstrobl @spring-projects-issues @hwan33