Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect or incomplete Javadoc in public APIs #2602

Open
jxblum opened this issue Apr 12, 2022 · 4 comments
Open

Fix incorrect or incomplete Javadoc in public APIs #2602

jxblum opened this issue Apr 12, 2022 · 4 comments
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: documentation A documentation update

Comments

@jxblum
Copy link
Contributor

jxblum commented Apr 12, 2022

Many of the classes (and APIs) in the Spring Data Commons core codebase have incomplete or incorrect Javadoc.

@jxblum jxblum added type: documentation A documentation update status: ideal-for-contribution An issue that a contributor can help us with labels Apr 12, 2022
@jxblum jxblum changed the title Fix incorrect or incomplete Javadoc in production classes Fix incorrect or incomplete Javadoc in public APIs Apr 12, 2022
@aml8801
Copy link

aml8801 commented May 30, 2022

Is this Issue still open? Could you give me hint about the standard, which should be used?

@jxblum
Copy link
Contributor Author

jxblum commented Jun 2, 2022

Fixing Javadoc in Spring Data Commons will most likely be a multi-part development effort.

A good first step would be to simply make sure that any Javadoc on a class or method is complete, i.e. does not have empty Javadoc tags for type parameter(s)/variable(s), method parameters (@param), @return values, @throws clauses, etc. A informative and proper description should be added wherever there are missing Javadoc, which the IDE flags as a warning.

Here is 1 such example.

This (here) is incomplete. This is, it does not "describe" the entity.

Here is another example.

These type of Javadoc problems are littered throughout the codebase.

@ukasus
Copy link

ukasus commented Sep 8, 2023

Hi , is this issue still open?

@jxblum
Copy link
Contributor Author

jxblum commented Sep 8, 2023

Yes, this is an ongoing effort. As a team, we decided to make changes to the Javadoc as we go, addressing issues or enhancements in the codebase along the way. Therefore, I would expect it would take sometime before all the Javadoc is completely reviewed and edited since it is not a focused effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

3 participants