Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade the deploy maven plugin to version 3.1.1 #43124

Closed
jabrena opened this issue Nov 12, 2024 · 5 comments
Closed

Downgrade the deploy maven plugin to version 3.1.1 #43124

jabrena opened this issue Nov 12, 2024 · 5 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@jabrena
Copy link

jabrena commented Nov 12, 2024

Hi,

Last week, we experimented an issue upgrading a Spring Boot project to the version 3.3.4 in the maven goal to deploy artifacts into JFROG Artifactory & Azure Packages with a set custom Spring Boot Starter libraries.


_[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:3.1.3:deploy (default-cli) on project sdk-parent: Failed to deploy artifacts: Could not transfer artifact sdk-parent:pom:0.1.0 from/to releases (https://my-domain.com/artifactory/libs-releases): transfer failed for https://my-domain/artifactory/libs-releases/sdk-parent/0.1.0/sdk-parent-0.1.0.pom, status: 409 -> [Help 1]
[ERROR]


after several tests, we found the following issues reported previously:

and all tickets are related with deploy-maven-plugin plugin.

I would like to share that the issue persists in Spring Boot 3.3.4 for some scenarios where you release Parent POMs.

If you observe, Spring Boot add deploy-maven-plugin version 3.1.3 to developers, but latest version didn´t fix that issue.

I propose the action to downgrade deploy-maven-plugin to the version version 3.1.1 until the plugin is fixed:
https://github.com/spring-projects/spring-boot/blob/main/spring-boot-project/spring-boot-dependencies/build.gradle#L1272-L1281

Current workaround in Azure Pipelines which it is working for us:

          - task: Maven@4
            displayName: Deploy jar
            inputs:
              mavenPomFile: 'pom.xml'
              goals: 'jar:jar org.apache.maven.plugins:maven-deploy-plugin:3.1.1:deploy'
              ...

What do you think?

Many thanks in advance

Juan Antonio

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 12, 2024
@philwebb
Copy link
Member

I'm not sure that we should downgrade at this point as this really feels like something that should be fixed in the Maven plugin. Flagging to see what the team think.

In the meantime, you can also add this to your pom.xml:

<properties>
    <maven-deploy-plugin.version>3.1.1</maven-deploy-plugin.version>
</properties>

@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label Nov 12, 2024
@snicoll
Copy link
Member

snicoll commented Nov 12, 2024

I agree that we shouldn’t downgrade. Affected users should as Phil pointed out.

@mhalbritter
Copy link
Contributor

I agree.

@jabrena
Copy link
Author

jabrena commented Nov 13, 2024

Oki, I will continue the conversation in the JIRA ticket not closed for this particular plugin.

I propose not close this ticket meanwhile the ticket related to this open issue is not closed in the plugin. Maybe other consumers will update to 3.3.x soon and maybe others will have this kind of issue.

https://spring.io/projects/spring-boot#support

image

Many thanks for your quick feedback, always is appreciated :)

@snicoll
Copy link
Member

snicoll commented Nov 13, 2024

Thanks for the suggestion but as it is, this issue is no longer actionable.

@snicoll snicoll closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2024
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

No branches or pull requests

5 participants