-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watcher isn't triggering refresh when the target service is in another namespace. #1781
Comments
sorry, "but isn't working" is not something we can work with. We need a sample with clear instructions what you expect to happen and it does not. May be a github repo you can create, with clear steps:
Something along these lines. If you could create such a sample, things would be much simpler for us to re-produce and help you. May be this is worth a read also. Btw, I see this in your logs: "Scheduling remote refresh event to be published for config-map: with appName : helloworld-service to be published in 30000 milliseconds", so the watcher detected the change and did send it to your |
Hi @wind57 , thanks for your comment. I am expecting the watcher to call the refresh endpoint after 30 seconds once the change was detected, but it is not happening. the watcher detected the change and scheduled the refresh but after 30 seconds it did not send the request, it does not log anything about it, in fact the log you should see is something like the following:
The helloworld-service exists in the hello-world namespace and the watcher is deployed in the spring-cloud-system namespace. What I did was the following
and then I wait 30 seconds until magic happens, but it didn't send the request T.T... Once thing important to mention, I did the same exercise installing the watcher and discovery in the same namespace as helloworld-service and it works like a charm. PS: Ill prepare a repository with the example. |
I'll wait for your example so that I could reproduce it, because we have integration tests that test this specific case: watcher in one namespace, service in another namespace... |
@ryanjbaxter can you add please the feedback label in here? |
Hello, we have exactly the same problem. @wind57 if you are refering to those integration tests: the config-watcher and the wiremock are deployed to the same namespace (default) so this quote imo is not true
|
I actually did not search when posting that quote, I should have added a "iirc". If you have the same problem, can you provide a reproducer then? thank you |
I might squeeze some time in the near future to test this one out too |
@wind57 I was finally able to work on packaging the example https://github.com/framled/hello-configmaps-watcher |
I've started to look into your sample, but there are a lot of things there un-related to the issue itself. Is there a chance you could clean it up and make it simpler please? |
yeah sure, I'll clean that up |
I know the struggle to create such a sample, because of the number of parameters involved... Also, I think its about time I create various samples with working projects that I can refer to in the future. It would be easier for everyone to bounce off. So here is a working example: https://github.com/wind57/spring-k8s-samples/tree/config-watcher-multiple-namespaces there is a configmap in namespace Thank you. |
@ryanjbaxter imho, this can be closed as I have tested it and provided a working sample. |
I will mark it as waiting for feedback and if we don't hear back the bot will close it. |
Works like a charm, thanks wind57 <3 |
the properties should be documented, but if you are only starting out with this project, it might be complicated to understand what refers to what. So I will maintain and create more samples in that repo. If this works for you, you can close the ticket then. thank you |
@ryanjbaxter can you please put the feedback tag back please? |
Describe the bug
Watcher is not triggering refresh when the target service is in another namespace.
I have this configmap which need to be shared between multiple services in different namespaces, I change the roles and the bindings to cluster roles, but isn't working. there is anything else that I should do or is not intended to work like that?
I leave the definitions for each service, config and logs.
watcher.yaml
discovery.yaml
config.yaml
watcher logs
The text was updated successfully, but these errors were encountered: