Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repackage spring-cloud-kubernetes-configserver so that it can also be used as a dependency #1456

Open
tspoeri opened this issue Sep 26, 2023 · 5 comments

Comments

@tspoeri
Copy link

tspoeri commented Sep 26, 2023

I am trying to add security to the spring-cloud-kubernetes-configserver, and the only way I see is to fork the project and add the necessary changes like dependencies and configuration.

It would be great if the spring-cloud-kubernetes-configserver was packaged in a way that it can be either directly launched as a service (the way it is today) or that it can also be used as a dependency for a custom built config server with enhanced functionality (similar to the spring-cloud-config-server on which it is based).

There seems to be a simple solution that only involves changing the classifier in the repackage goal of the build script that would allow both usages, as described here: https://stackoverflow.com/questions/40089443

@ryanjbaxter
Copy link
Contributor

Makes sense, PRs welcome if you are interested

@pepanek
Copy link

pepanek commented Nov 19, 2024

I’d like to help because we’ll need this as well. However, I’m not entirely sure how to proceed. Could you please point me to a guideline or provide some instructions?

@ryanjbaxter
Copy link
Contributor

@pepanek would love some help! If you form the project make the changes and submit a PR we can go from there

@pepanek
Copy link

pepanek commented Nov 22, 2024

Alright, could you please add me to the project in github so I have the permissions to push a branch?

@ryanjbaxter
Copy link
Contributor

You just need to fork the project and that way you can push branches to your own fork
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants