Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecutionContext inconsistent in API responses. #1631

Closed
jvalkeal opened this issue Aug 15, 2017 · 3 comments
Closed

ExecutionContext inconsistent in API responses. #1631

jvalkeal opened this issue Aug 15, 2017 · 3 comments
Labels
type/technical-debt Techical Dept

Comments

@jvalkeal
Copy link
Contributor

I ran timestamp-batch app and then checked json responses what UI queries.

If we check below responses, /jobs/executions/1/steps/1 vs. /jobs/executions/1, executionContext is reported

"executionContext": {
  "dirty": true,
  "empty": false,
  "values": [
        {
          "batch.taskletType": "org.springframework.cloud.task.app.timestamp.batch.TimestampBatchTaskConfiguration$1"
        },
        {
          "batch.stepType": "org.springframework.batch.core.step.tasklet.TaskletStep"
        }
  ]
}
"executionContext": {
  "dirty": false,
  "empty": true,
  "values": []
}

Full responses.

{
  "jobExecutionId": 1,
  "stepExecution": {
    "id": 1,
    "version": 3,
    "stepName": "job1step1",
    "status": "COMPLETED",
    "readCount": 0,
    "writeCount": 0,
    "commitCount": 1,
    "rollbackCount": 0,
    "readSkipCount": 0,
    "processSkipCount": 0,
    "writeSkipCount": 0,
    "startTime": "2017-08-11T06:15:50.046Z",
    "endTime": "2017-08-11T06:15:50.064Z",
    "lastUpdated": "2017-08-11T06:15:50.064Z",
    "executionContext": {
      "dirty": true,
      "empty": false,
      "values": [
        {
          "batch.taskletType": "org.springframework.cloud.task.app.timestamp.batch.TimestampBatchTaskConfiguration$1"
        },
        {
          "batch.stepType": "org.springframework.batch.core.step.tasklet.TaskletStep"
        }
      ]
    },
    "exitStatus": {
      "exitCode": "COMPLETED",
      "exitDescription": "",
      "running": false
    },
    "terminateOnly": false,
    "filterCount": 0,
    "failureExceptions": [
      
    ],
    "skipCount": 0,
    "summary": "StepExecution: id=1, version=3, name=job1step1, status=COMPLETED, exitStatus=COMPLETED, readCount=0, filterCount=0, writeCount=0 readSkipCount=0, writeSkipCount=0, processSkipCount=0, commitCount=1, rollbackCount=0",
    "jobParameters": {
      "parameters": {
        "-spring.cloud.task.executionid": {
          "identifying": false,
          "value": "2",
          "type": "STRING"
        }
      },
      "empty": false
    },
    "jobExecutionId": 1
  },
  "stepType": "org.springframework.cloud.task.app.timestamp.batch.TimestampBatchTaskConfiguration$1",
  "_links": {
    "self": {
      "href": "http://localhost:9393/jobs/executions/1/steps/1"
    }
  }
}
{
  "executionId": 1,
  "stepExecutionCount": 1,
  "jobId": 1,
  "taskExecutionId": 2,
  "name": "job1",
  "startDate": "2017-08-11",
  "startTime": "06:15:50",
  "duration": "00:00:00",
  "jobExecution": {
    "id": 1,
    "version": 2,
    "jobParameters": {
      "parameters": {
        "-spring.cloud.task.executionid": {
          "identifying": false,
          "value": "2",
          "type": "STRING"
        }
      },
      "empty": false
    },
    "jobInstance": {
      "id": 1,
      "version": 0,
      "jobName": "job1",
      "instanceId": 1
    },
    "stepExecutions": [
      {
        "id": 1,
        "version": 3,
        "stepName": "job1step1",
        "status": "COMPLETED",
        "readCount": 0,
        "writeCount": 0,
        "commitCount": 1,
        "rollbackCount": 0,
        "readSkipCount": 0,
        "processSkipCount": 0,
        "writeSkipCount": 0,
        "startTime": "2017-08-11T06:15:50.046Z",
        "endTime": "2017-08-11T06:15:50.064Z",
        "lastUpdated": "2017-08-11T06:15:50.064Z",
        "executionContext": {
          "dirty": false,
          "empty": true,
          "values": [
            
          ]
        },
        "exitStatus": {
          "exitCode": "COMPLETED",
          "exitDescription": "",
          "running": false
        },
        "terminateOnly": false,
        "filterCount": 0,
        "failureExceptions": [
          
        ],
        "skipCount": 0,
        "summary": "StepExecution: id=1, version=3, name=job1step1, status=COMPLETED, exitStatus=COMPLETED, readCount=0, filterCount=0, writeCount=0 readSkipCount=0, writeSkipCount=0, processSkipCount=0, commitCount=1, rollbackCount=0",
        "jobParameters": {
          "parameters": {
            "-spring.cloud.task.executionid": {
              "identifying": false,
              "value": "2",
              "type": "STRING"
            }
          },
          "empty": false
        },
        "jobExecutionId": 1
      }
    ],
    "status": "COMPLETED",
    "startTime": "2017-08-11T06:15:50.027Z",
    "createTime": "2017-08-11T06:15:49.989Z",
    "endTime": "2017-08-11T06:15:50.067Z",
    "lastUpdated": "2017-08-11T06:15:50.067Z",
    "exitStatus": {
      "exitCode": "COMPLETED",
      "exitDescription": "",
      "running": false
    },
    "executionContext": {
      "dirty": false,
      "empty": true,
      "values": [
        
      ]
    },
    "failureExceptions": [
      
    ],
    "jobConfigurationName": null,
    "allFailureExceptions": [
      
    ],
    "running": false,
    "stopping": false,
    "jobId": 1
  },
  "jobParameters": {
    "--spring.cloud.task.executionid": "2"
  },
  "jobParametersString": "--spring.cloud.task.executionid=2",
  "restartable": false,
  "abandonable": false,
  "stoppable": false,
  "defined": true,
  "timeZone": "UTC",
  "_links": {
    "self": {
      "href": "http://localhost:9393/jobs/executions/1"
    }
  }
}
@sabbyanandan
Copy link
Contributor

@jvalkeal: When you get a chance, can you verify whether if the inconsistency exist? Either way, I don't see it causing harm for the users, though.

@ilayaperumalg
Copy link
Contributor

Not sure how effectively is this being used and we don't show this at the dashboard as well.

@ilayaperumalg ilayaperumalg added the type/help-needed Calling help label Nov 9, 2020
@sabbyanandan sabbyanandan removed the type/help-needed Calling help label May 24, 2021
@cppwfs
Copy link
Contributor

cppwfs commented Nov 12, 2024

Closing this issue due to inactivity. If you think this is closed in error please leave a comment.

@cppwfs cppwfs closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/technical-debt Techical Dept
Projects
None yet
Development

No branches or pull requests

4 participants