Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release with Python3.11 Support? #355

Open
Bastian-Krause opened this issue Jan 25, 2023 · 8 comments
Open

New Release with Python3.11 Support? #355

Bastian-Krause opened this issue Jan 25, 2023 · 8 comments

Comments

@Bastian-Krause
Copy link

Bastian-Krause commented Jan 25, 2023

#354 added Python3.11 support for dh-virtualenv. Since Debian sid currently ships its python3 package in version 3.11.1-1, the currently released dh-virtualenv version 1.2.2 does not work.

I saw that @nailor is also the Debian maintainer for dh-virtualenv, it would be best to have a new release and a corresponding Debian package version. I could alternatively send a backport of the patch in #354 as a Debian bug report.

What do you think?

@ukleinek
Copy link
Contributor

my 2¢: If I understand correctly, Debian testing is also affected and the problem makes dh-virtualenv useless for all users?!

That would justify a bugreport with severity grave against the version in testing which would result in the package being dropped from testing. The next consequence would be that dh-virtualenv is missing in the next release if it's not fixed in a timely manner[1].

[1] https://release.debian.org/bullseye/freeze_policy.html

@Bastian-Krause
Copy link
Author

Bastian-Krause commented Jan 27, 2023

my 2¢: If I understand correctly, Debian testing is also affected and the problem makes dh-virtualenv useless for all users?!

Currently Debian Bookworm ships Python 3.10, I guess they will not bump it to 3.11 before the freeze, right? So when Debian Trixie becomes Testing, that will be affected.

@jluebbe
Copy link

jluebbe commented Jan 29, 2023

The default Python in Debian bookworm is now 3.11: https://tracker.debian.org/news/1414484/python3-defaults-3111-1-migrated-to-testing/

@Bastian-Krause Bastian-Krause changed the title New Release with Python3.11 Support? Debian 12+ Broken - New Release with Python3.11 Support? Jan 30, 2023
@ikus060
Copy link

ikus060 commented Jan 30, 2023

I'm also affected by this problem. Our build depend on dh-virtualenv and it's fail on Bookworm with the following error:

Traceback (most recent call last):
  File "/usr/bin/dh_virtualenv", line 111, in <module>
    sys.exit(main() or 0)
             ^^^^^^
  File "/usr/bin/dh_virtualenv", line 60, in main
    arguments = inspect.getargspec(DebHelper.__init__).args
                ^^^^^^^^^^^^^^^^^^
AttributeError: module 'inspect' has no attribute 'getargspec'. Did you mean: 'getargs'?

Seams related to the fact Bookworm is now using Python3.11 by default.

@Bastian-Krause
Copy link
Author

For the record: in Debian's dh-virtualenv 1.2.2-1.3 the patch from #354 was cherry-picked as NMU. A dh-virtualenv release including this would still be nice.

@Bastian-Krause Bastian-Krause changed the title Debian 12+ Broken - New Release with Python3.11 Support? New Release with Python3.11 Support? Mar 15, 2023
@ikus060
Copy link

ikus060 commented Mar 17, 2023

@Bastian-Krause

dh-virtualenv 1.2.2-1.3 the patch from #354 was cherry-picked as NMU

Does it mean dh-virtualenv should work in Debian Bookworm ?

@Bastian-Krause
Copy link
Author

@Bastian-Krause

dh-virtualenv 1.2.2-1.3 the patch from #354 was cherry-picked as NMU

Does it mean dh-virtualenv should work in Debian Bookworm ?

Yes: https://packages.debian.org/bookworm/dh-virtualenv (changelog). Works for me.

@wferi
Copy link

wferi commented Sep 27, 2024

Please consider cutting a new release, several fixes on the master branch did not make it into distro packages yet (like for example enabling --verbose with --builtin-venv).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants