Is impsort needed?

[elharo]

saw this:

[INFO] 
[INFO] --- formatter:2.24.1:format (default) @ spotbugs-maven-plugin ---
[INFO] 
[INFO] --- impsort:1.12.0:sort (default) @ spotbugs-maven-plugin ---
[INFO] Processed 0 files in 00:00.000 (Already Sorted: 0, Needed Sorting: 0)
[INFO] 

The build also uses spotless, which also sorts imports. Possibly impsort is redundant.

[hazendaz]

I'm part of the impsort project team, I find it works better in general so I plan to keep that even if spotless is trying to do everything possible. I would be interested in if spotless can get rid of star imports though. That is why I'm using open rewrite which appears to be removing unused imports. Its not really, they have hidden replacement of star imports with full imports inside that so I use that for that reason only but open rewrite is a mess and doesn't work as globally as one would wish. I have sparingly been using spotless for certain features and haven't looked in quite some time to see what it might support now. I did a quick look around yesterday but was not seeing any such feature called out to remove star imports.

[elharo]

just tried this and it appears spotless does not remove * imports

[hazendaz]

ok thanks for confirming. Will give that a go to reconfirm and if good, will dump open rewrite all together there in my base parent as its IMO rather useless as poorly as it works. For what I've used spotless thus far its always just worked :)