Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After recent updates in core libraries ad plugin verify and spotbugs:check works differently #806

Open
romani opened this issue May 7, 2024 · 0 comments
Assignees

Comments

@romani
Copy link

romani commented May 7, 2024

before spotbugs/spotbugs#2759 and
spotbugs/spotbugs#2819

we did not notice problem that mvn verify and mvn clean test-compile spotbugs:check works differently.
Due to issues above we disabled mvn clean test-compile spotbugs:check in CI, after activation back
we noticed that spotbugs reports violation, I checked on local - same violations: checkstyle/checkstyle#14863

Other CIs are green, and mvn verify on local report 0 violation.

violation from mvn clean test-compile spotbugs:check is false positives:

[ERROR] High: Nullcheck of valuesStream at line 1056 of value previously dereferenced in com.puppycrawl.tools.checkstyle.site.SiteUtil.getStringArrayPropertyValue(String, Object) [com.puppycrawl.tools.checkstyle.site.SiteUtil, com.puppycrawl.tools.checkstyle.site.SiteUtil] At SiteUtil.java:[line 1056]Redundant null check at SiteUtil.java:[line 1059] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE

[ERROR] Low: Method com.puppycrawl.tools.checkstyle.utils.JavadocUtil.getJavadocTags(TextBlock, JavadocUtil$JavadocTagType) appears to call the same method on the same object redundantly [com.puppycrawl.tools.checkstyle.utils.JavadocUtil] At JavadocUtil.java:[line 119] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS

[ERROR] Low: Method com.puppycrawl.tools.checkstyle.utils.JavadocUtil.getJavadocTags(TextBlock, JavadocUtil$JavadocTagType) appears to call the same method on the same object redundantly [com.puppycrawl.tools.checkstyle.utils.JavadocUtil] At JavadocUtil.java:[line 123] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS

[ERROR] Medium: Method com.puppycrawl.tools.checkstyle.Main.main(String[]) has abnormal exit from finally block [com.puppycrawl.tools.checkstyle.Main] At Main.java:[line 155] AFBR_ABNORMAL_FINALLY_BLOCK_RETURN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants