Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-add-seg-only generates JSON sidecars with "Name": "Manual" #78

Open
valosekj opened this issue Feb 2, 2024 · 0 comments
Open

-add-seg-only generates JSON sidecars with "Name": "Manual" #78

valosekj opened this issue Feb 2, 2024 · 0 comments

Comments

@valosekj
Copy link
Member

valosekj commented Feb 2, 2024

When using manual-correction.py -add-seg-only to copy the source segmentations (i.e., automatically generated (e.g., by sct_deepseg_sc or SCIseg) and visually verified in HTML QC) to the final git-annex dataset, manual-correction.py generates the following JSON sidecar containing "Name": "Manual", for example:

{
    "SpatialReference": "orig",
    "GeneratedBy": [
        {
            "Name": "Manual",
            "Author": "Jan Valosek",
            "Date": "2024-02-02 08:50:37"
        }
    ]
}

But since the segmentations were generated automatically, e.g., by sct_deepseg_sc or SCIseg, the JSON should rather look like:

{
    "SpatialReference": "orig",
    "GeneratedBy": [
        {
            "Name": "SCIseg nnUNet3D",
            "Version": "https://github.com/ivadomed/model_seg_sci/releases/tag/r20240130",
            "Date": "2024-02-01"
        }
    ]
}

Related: #76, #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant