Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify warnings handling #64

Open
valosekj opened this issue Sep 15, 2023 · 0 comments
Open

Unify warnings handling #64

valosekj opened this issue Sep 15, 2023 · 0 comments
Assignees
@valosekj

Comments

@valosekj
Copy link
Member

Instead of print(f'WARNING!)

manual-correction/manual_correction.py

Line 542 in 8adb172

print(f'WARNING! The file {fname_out} already exists.')

It would be better to use logging.warning(f"") , as done, for example:

manual-correction/manual_correction.py

Line 595 in 8adb172

logging.warning(f"File {fname_label} is empty. Skipping QC.\n")

@valosekj valosekj self-assigned this Sep 15, 2023
@valosekj valosekj changed the title Unifying warnings handling Unify warnings handling Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valosekj valosekj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@valosekj