Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-change-orient flag manipulates the original image #101

Open
valosekj opened this issue Jul 1, 2024 · 0 comments
Open

-change-orient flag manipulates the original image #101

valosekj opened this issue Jul 1, 2024 · 0 comments

Comments

@valosekj
Copy link
Member

valosekj commented Jul 1, 2024

The recently added -change-orient flag (#100) works as follows:

  1. Fetch the original orientation of the image and label
  2. Change the orientation of the image and label to the orientation specified by -change-orient
  3. Open the viewer
  4. Change the orientation of the image and label back to the original orientation

This works fine if all the steps are executed. However, when the correction process is interrupted, for example, by pressing ctrl + C during steps 2 and 3, the orientation of the image and label will stay changed. This might be suboptimal as we are manipulating the original image.

For now, I have cross-refed this issue to the -change-orient help (9a57a8e).
A long-term solution might involve creating a tmp directory, copying the original files and reorienting these copies.

valosekj added a commit that referenced this issue Jul 1, 2024
valosekj added a commit that referenced this issue Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant