Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent X-Y location of labels for PAM50_label_body.nii.gz #22

Open
jcohenadad opened this issue Aug 9, 2023 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@jcohenadad
Copy link
Member

jcohenadad commented Aug 9, 2023

Context

From forum post: https://forum.spinalcordmri.org/t/registration-of-lumbar-data-to-pam50/1109

While working with the labels I saw that the PAM_label_body usually places the label at 70/70/xx but labels 15:18,20 are at 70/71/xx, so one voxel more anterior. Maybe this is intentional but it looked a bit unusual.

The reason for this inconsistency is likely because labels were created at the center of mass of the cord segmentation, which happens to be slightly shifted along the A-P direction depending on the S-I location.

Solution

We could re-generate all labels, making sure they are centered at x=70, y=70.

Pros:

  • Easier to visualise
  • Less confusing for users

Cons:

  • Labels are not centered according to the center of mass anymore (ie: 70,70 is kind of 'arbitrary'). Although this is a minor cons.

Important
We should make sure that, if other PAM50 label files are also affected by this problem, we also fix them in the same PR.

@jcohenadad jcohenadad self-assigned this Aug 9, 2023
@jcohenadad jcohenadad added the enhancement New feature or request label Aug 9, 2023
@jcohenadad
Copy link
Member Author

Alternatively, remove that file, see spinalcordtoolbox/spinalcordtoolbox#4229

Also related to #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant