Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video loader crashes when reading past end of file #140

Open
spillerrec opened this issue Aug 3, 2019 · 1 comment
Open

Video loader crashes when reading past end of file #140

spillerrec opened this issue Aug 3, 2019 · 1 comment
Labels
bug
Milestone
Version 0.4

Comments

@spillerrec
Copy link
Owner

Describe the bug
The video loader loads X frames from a file, but if this means the last frame is after the end of the video, it will still try to load those frames and crash due to them not being available.
@spillerrec spillerrec added the bug label Aug 3, 2019
@spillerrec spillerrec added this to the Version 0.4 milestone Aug 3, 2019
spillerrec added a commit that referenced this issue Aug 4, 2019
@spillerrec
QUICK-FIX: Don't crash on exceptions in VideoImporter #140
651dab1
@spillerrec
Copy link
Owner Author

It did not crash due to being unable to read the frames, it threw an exception upon reaching the end and the importer dialog did not handle this, causing the crash. It now catches the exception so the crash is avoided, but it would be nice with a bit smoother handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Version 0.4
Development

No branches or pull requests
1 participant
@spillerrec