Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt users to open Readme on developer's request #346

Open
kyrie25 opened this issue Oct 8, 2022 · 5 comments
Open

Prompt users to open Readme on developer's request #346

kyrie25 opened this issue Oct 8, 2022 · 5 comments
Labels
💫 enhancement New feature or request

Comments

@kyrie25
Copy link
Member

kyrie25 commented Oct 8, 2022

📝 Provide a description of the new feature

There are currently themes and extensions that has this issue (eg. Dribbblish Dynamic) where the users are required to install the theme/extension locally or to take extra steps before installing, and that Marketplace installation doesn't work properly for them.

In order for theme/extension developers to not feel discouraged from publishing to Marketplace, I'd suggest making an additional field on the manifest format that requests Marketplace to open its Readme and read the requirements before installing (boolean value).

➕ Additional Information

Currently I can think of a few ways to do this:

  • For the specified theme/extension, replace the Install button on Cards to the GitHub icon, on click it would prompt the user with a modal which would open the Readme externally (on their browser etc.).

This means that users will have to install said theme/extension via the CLI.

  • We could also use the GitHub icon but open the Readme inside Marketplace itself, with a notification shown that tells the user to read the Readme beforehand and then they can install the theme/extension using the button inside the Readme page.

This means that users can still install said theme/extension via Marketplace, and the extension/theme devs can include whether it should be installed Marketplace or not.

@CharlieS1103
Copy link
Member

CharlieS1103 commented Oct 8, 2022

@kyrie25 Rather than having it open up the entire readme, could we instead allow the extension/theme owners to open any .MD file in the repo to allow more room for customization, we can simply have an optional parameter in the manifest titled "special-instructions" or "force-open" or something of the like.

@kyrie25
Copy link
Member Author

kyrie25 commented Oct 8, 2022

The general idea is that it prevents themes/extensions breaking from installing on Marketplace so yeah whichever works.

@theRealPadster
Copy link
Member

What doesn't work when installed via marketplace? Themes have the "include" array to bundle extensions in them.

@kyrie25
Copy link
Member Author

kyrie25 commented Oct 8, 2022

What doesn't work when installed via marketplace? Themes have the "include" array to bundle extensions in them.

Stuff like Dribs, Dribs Dynamic & Default not working properly since it requires libraries to be loaded early or requires extra patching in config-xpui, etc.
Would be nice for extensions that wants to use custom hooks also.
image

@theRealPadster
Copy link
Member

Ah, right, didn't think of that. I think it's probably easier to support just having it open externally and make them install via cli. Otherwise you'll have people with weird hybrids

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💫 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants