Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logo_name = None not handled properly, appears in sidebar #216

Open
sloria opened this issue Jan 18, 2024 · 1 comment
Open

logo_name = None not handled properly, appears in sidebar #216

sloria opened this issue Jan 18, 2024 · 1 comment

Comments

@sloria
Copy link
Contributor

sloria commented Jan 18, 2024

Related to the fix for #215 in 39cbbc1 .

I worked around the previous issue #215 by setting logo_name to None in html_theme_options:

html_theme_options = {
    "logo": "marshmallow-logo.png",
    "logo_name": None,
    # ...
}

but when I upgrade to alabaster 0.7.16, None appears in the sidebar

Firefox 2024-01-18 at 12 45 36

This is easily fixed by removing the logo_name setting, but the template should also properly handle None.

sloria added a commit to marshmallow-code/marshmallow-sqlalchemy that referenced this issue Jan 19, 2024
@picnixz
Copy link
Member

picnixz commented Mar 3, 2024

PR welcome !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants