Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in the __call__ method of ImageOverlay #444

Open
btessore opened this issue Oct 10, 2024 · 2 comments
Open

Error in the __call__ method of ImageOverlay #444

btessore opened this issue Oct 10, 2024 · 2 comments

Comments

@btessore
Copy link

There is a minor bug in the call of augraphy.utilities.imageoverlay.ImagOverlay
Parenthesis are missing in image.copy.

image.copy should be image.copy()

Also,
the class returns the a RGBA image (H,W,4) instead of a 1 or 3 channels image. I'm not sure if it is the intended meaning.

cheers

@jboarman
Copy link
Member

jboarman commented Oct 10, 2024

Hi @btessore! It's always great to see someone identify a bug, so now we can make things even better!

Would you be able to prepare a pull request, or even a more complete code snippet identifying what fix is needed and confirm on your end that it resolves the issue?

@kwcckw
Copy link
Collaborator

kwcckw commented Oct 13, 2024

Hi, ImageOverlay is an internal function and actually it's obsolete now.

The similar functionality is replaced by OverlayBuilder now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants