Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request and Response standards #1039

Open
dave42w opened this issue Nov 19, 2024 · 0 comments
Open

Request and Response standards #1039

dave42w opened this issue Nov 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@dave42w
Copy link
Contributor

dave42w commented Nov 19, 2024

I'm wondering if we could migrate to using a "standard" or at least very common model for requests and responses.

What I'm thinking is using the wrappers from Werkzeug https://werkzeug.palletsprojects.com/en/stable/wrappers/#werkzeug.wrappers.Request as Flask and many other projects do.

My thinking is that there is a lot of well-proven and thorough work there and it would make migrating web apps from the most popular web frameworks to Robyn much easier.

I'd do this by making our request a subclass of the Werkzeug request. That way we can provide both our existing interface and the Werkzeug one to our endpoints. Eventually we can deprecate our version and encourage people to move towards the Werkzeug interface.

Thoughts?

@dave42w dave42w added the enhancement New feature or request label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant