RCAL-942: Remove Units from Reference File Datamodels #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Dark Current
Photom
ramp_fitting
jump
testing
Saturation
dependencies
for more information, see https://pre-commit.ci
…mancal into RCAL-942_RemoveUnits
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1474 +/- ##
==========================================
- Coverage 76.15% 76.13% -0.02%
==========================================
Files 115 115
Lines 7638 7632 -6
==========================================
- Hits 5817 5811 -6
Misses 1821 1821 ☔ View full report in Codecov by Sentry. |
|
That looks good. Hopefully we will hear this afternoon on the status of making new unit-free ref files. |
|
As expected, there are some failing regression files that need new reference files: |
PaulHuwe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-942
Closes #1472
This PR removes units from reference file datamodels.
Tasks
24Q4_B15(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)docs/pageokify_regteststo update the truth filesnews fragment change types...
changes/<PR#>.general.rst: infrastructure or miscellaneous changechanges/<PR#>.docs.rstchanges/<PR#>.stpipe.rstchanges/<PR#>.associations.rstchanges/<PR#>.scripts.rstchanges/<PR#>.mosaic_pipeline.rstchanges/<PR#>.patch_match.rststeps
changes/<PR#>.dq_init.rstchanges/<PR#>.saturation.rstchanges/<PR#>.refpix.rstchanges/<PR#>.linearity.rstchanges/<PR#>.dark_current.rstchanges/<PR#>.jump_detection.rstchanges/<PR#>.ramp_fitting.rstchanges/<PR#>.assign_wcs.rstchanges/<PR#>.flatfield.rstchanges/<PR#>.photom.rstchanges/<PR#>.flux.rstchanges/<PR#>.source_detection.rstchanges/<PR#>.tweakreg.rstchanges/<PR#>.skymatch.rstchanges/<PR#>.outlier_detection.rstchanges/<PR#>.resample.rstchanges/<PR#>.source_catalog.rst