Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter CRPIX to the resample step should be 1-based following FITS WCS convention #9015

Open
stscijgbot-jp opened this issue Dec 18, 2024 · 0 comments

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-3823 was created on JIRA by Mihai Cara:

Documentation for the resample step does not specify indexing convention for the CRPIX parameter (custom WCS). Documentation should be updated that CRPIX value is 1-based just like in the FITS WCS standard AND stcal code should be updated accordingly. Currently the code in _calculate_offsets() is written with the assumption that CRPIX is 0-based. This can create inconsistencies and confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant