Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The maskpt parameter in outlier detection is not useful for TSO data #8879

Open
emolter opened this issue Oct 11, 2024 · 0 comments
Open

The maskpt parameter in outlier detection is not useful for TSO data #8879

emolter opened this issue Oct 11, 2024 · 0 comments

Comments

@emolter
Copy link
Collaborator

emolter commented Oct 11, 2024

For outlier detection in TSO mode, the weight array is always just a DQ mask, so its values are either 0 or 1. It is then passed into a function that compares the weights with a threshold set by the maskpt parameter here. But this is confusing, and renders the maskpt essentially pointless for any reasonable value, because all the weights are either 0 or 1. That parameter should be removed as an input to the TSO mode, and the call to compute_weight_threshold should be replaced with something that more clearly indicates what actually happens.

edit: the same appears to be true for coronagraphic data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant