Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testbed to read service IDs from more than just services.yml #210

Open
ivalaginja opened this issue May 31, 2024 · 0 comments
Open

Testbed to read service IDs from more than just services.yml #210

ivalaginja opened this issue May 31, 2024 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@ivalaginja
Copy link
Collaborator

ivalaginja commented May 31, 2024

The testbed explicitly collects all service IDs found in services.yml:

for service_id, service_info in self.config['services'].items():

This happens in a couple more places in catkit2/testbed/testbed.py and in catkit2/testbed/testbed_proxy.py.

I am trying to come up with a way where I could have the testbed collect service IDs from more than just the services configuration. In particular, we have so many individual motor services on THD2 that I would like to separate them out into a file like motors.yml. It seems like it should be easy to optionally pass additional config keys that would also be used as a source for service IDs. I am just still trying to figure out how to implement that without a change that is too invasive, and most of all keep things working with the current default setup.

I also just saw there's some of that in catkit_core/Service.cpp:

m_Config = m_Testbed->GetConfig()["services"][service_id];

So I might have to be more careful with that.

@ivalaginja ivalaginja added enhancement New feature or request question Further information is requested labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant