Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't read the names of dark colored chemicals #29778

Open
engineer-pearl opened this issue Jul 6, 2024 · 3 comments
Open

Can't read the names of dark colored chemicals #29778

engineer-pearl opened this issue Jul 6, 2024 · 3 comments

Comments

@engineer-pearl
Copy link

Description

It's difficult to see the names of dark chemicals when looking at them with the Chem glasses.

Reproduction

  • Wear chem goggles
  • Make or find a darkly colored chemical
  • Examine the chemical

Screenshots
cant read this

Additional context
The issue is caused by using the color of the chemical to set the color of the chemical's name, but not adjusting the background of the examine window to compensate.

When I'm a chemist, I like to double-check my chemical before applying the label - a practice which prevents accidents in various situations. This is less effective when I cannot read the chemical's name.

@github-actions github-actions bot added the Status: Untriaged Somebody go through and give this appropriate labels label Jul 6, 2024
@IProduceWidgets
Copy link
Contributor

IProduceWidgets commented Jul 6, 2024

Hmm. That's a tricky one. Maybe we need a way to add text outlines to examine, because the color is supposed to mimic the solution's color and doesn't make sense to change.

Thinking more, I guess we could change the solution color too, but I think we're going to get colliding issues doing that.

@IProduceWidgets IProduceWidgets added Issue: Accessibility and removed Status: Untriaged Somebody go through and give this appropriate labels labels Jul 6, 2024
@engineer-pearl
Copy link
Author

I don't love the idea of trying to fix this by changing the solution color. At a minimum, that change would require identifying all dark colored chems, and would cut off about half the available color options.

Do you know if that component supports highlighting? If you could detect the approximate brightness of the color, you could utilize highlighting to apply a background to the label.

@EmoGarbage404
Copy link
Member

main two options are

  • white outline around the text (hard)
  • white background applied automatically to text that is under a certain darkness (also hard)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants