Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Blob view: revision selector is slow #57825

Closed
Tracked by #57711
camdencheek opened this issue Oct 23, 2023 · 3 comments
Closed
Tracked by #57711

Blob view: revision selector is slow #57825

camdencheek opened this issue Oct 23, 2023 · 3 comments

Comments

@camdencheek
Copy link
Member

camdencheek commented Oct 23, 2023

When first used, the revision selector takes a second or two to load. We should look into whether we can speed this up or preload it (depending on how frequently it's used).

CleanShot 2023-10-23 at 13 30 06@2x

@camdencheek
Copy link
Member Author

Looked into this a bit and found that, for each reference, we're making a followup git request to resolve the author information.

We looked into two ideas:

  1. use git for-each-ref to return a formatted list with all the authorship information in one go
  2. batch resolve the authorship information

The problem with both is we don't know in advance whether the authorship information is needed, and our GraphQL library doesn't support inspecting which fields are requested.

@camdencheek
Copy link
Member Author

camdencheek commented Jan 8, 2024

cc @fkling since we chatted briefly about why this is slow on the backend

@camdencheek
Copy link
Member Author

Closing since we don't plan to do any additional work here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant