Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not process notifications when there is a merge conflict #7

Open
unknwon opened this issue Nov 16, 2020 · 1 comment
Open

Do not process notifications when there is a merge conflict #7

unknwon opened this issue Nov 16, 2020 · 1 comment

Comments

@unknwon
Copy link
Member

unknwon commented Nov 16, 2020

This was one of the major issue we had with CODEOWNERS where when the PR has merge conflict with the target branch, it tags unrelated people for the unrelated files to the PR (due to the nature that GitHub currently considers all files in question to be part of changed files).

@piegamesde
Copy link

I generally agree, but there are more ways to create mass notifications even when there are no conflicts. Most of the time, this happens when wrong branches are selected for merging (for example when you change the target branch of a PR, a lot of commits get "added" that should not be part of it).

As an additional counter measure, I'd suggest checking for an excessive number of pinged people, commits or modified files. (Those numbers would probably need to be adjustable per repository.) The action should then comment with a warning asking for confirmation before pinging all those people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants